Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index pattern creation - text improvements #107860

Merged
merged 11 commits into from
Aug 16, 2021
Merged

Index pattern creation - text improvements #107860

merged 11 commits into from
Aug 16, 2021

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Aug 8, 2021 •
edited
Loading

Summary

Minor text improvements in follow up to #101853

Its worth noting that I tried to standardize around index alias instead of just alias as its a searchable technical term but if I'm causing trouble I'm happy change course.

gchaps
gchaps reviewed Aug 13, 2021
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ to index alias

Can you please provide screenshots that shows the latest for these two messages. I'd like to see how the final text looks.

  • The index pattern you entered doesn't match any indices. You can match 1 index below.

  • Your index pattern doesn't match an indices, but you have an index that looks similar.

...ugins/index_pattern_editor/public/components/preview_panel/status_message/status_message.tsx Outdated Show resolved Hide resolved
...ugins/index_pattern_editor/public/components/preview_panel/status_message/status_message.tsx Outdated Show resolved Hide resolved
...ugins/index_pattern_editor/public/components/preview_panel/status_message/status_message.tsx Outdated Show resolved Hide resolved
@mattkime
Copy link
Contributor Author

@gchaps Here are your requested screenshots -

Screen Shot 2021-08-13 at 12 48 56 PM

Screen Shot 2021-08-13 at 12 48 33 PM

@gchaps
Copy link
Contributor

gchaps commented Aug 13, 2021

A few comments:

Screen Shot 2021-08-13 at 1 04 36 PM

Is this hint text still correct. It only mentions indices. Or should it be "to match multiple sources" or "to match multiple characters"

Screen Shot 2021-08-13 at 1 04 43 PM

It seems to me that a word is needed after the number 1. Does this work:

Your index pattern doesn't match any data streams, indices, or index aliases, but 1 source is similar.
Your index pattern doesn't match any data streams, indices, or index aliases, but 2 sources are similar.

Screen Shot 2021-08-13 at 1 05 02 PM

How about this:

No data streams, indices, or index aliases match your index pattern. You can match 1 source.
No data streams, indices, or index aliases match your index pattern. You can match 2 sources.

@mattkime
Copy link
Contributor Author

Updated -

Screen Shot 2021-08-13 at 9 30 02 PM

Screen Shot 2021-08-13 at 9 29 40 PM

@mattkime mattkime marked this pull request as ready for review August 16, 2021 18:56
@mattkime mattkime added 8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes v7.15.0 labels Aug 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@mattkime
Copy link
Contributor Author

@elasticmachine merge upstream

gchaps
gchaps approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for updating the text.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
indexPatternEditor 104 103 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexPatternEditor 169.3KB 169.5KB +111.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit 0153bdb into elastic:master Aug 16, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 16, 2021
@mattkime @kibanamachine
Index pattern creation - text improvements (elastic#107860)
d5204f7 
* text improvements
@kibanamachine kibanamachine mentioned this pull request Aug 16, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 17, 2021
@kibanamachine @mattkime
Index pattern creation - text improvements (#107860) (#108806)
b0cb12e 
* text improvements

Co-authored-by: Matthew Kime <matt@mattki.me>
@lukasolson lukasolson added v8.0.0 and removed 8.0.0 labels Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattkime @gchaps @elasticmachine @kibanamachine @lukasolson